Skip to content

Conversation

@prakash100198
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented Sep 17, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13816532 Triggered Generic Private Key 7ce186d vendor/github.com/google/s2a-go/testdata/mds_client_key.pem View secret
13816533 Triggered Generic Private Key 7ce186d vendor/github.com/google/s2a-go/testdata/mds_server_key.pem View secret
13816534 Triggered Generic Private Key 7ce186d vendor/github.com/google/s2a-go/testdata/self_signed_key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

query := impl.scanListingQueryBuilder(request, size, offset, deployInfoIds)
_, err := impl.dbConnection.Query(&models, query, size, offset)
if len(request.Severity) > 0 {
_, err = impl.dbConnection.Query(&models, query, pg.In(request.Severity), pg.In(request.Severity))

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query depends on a [user-provided value](1).
if len(request.Severity) > 0 {
_, err = impl.dbConnection.Query(&models, query, pg.In(request.Severity), pg.In(request.Severity))
} else {
_, err = impl.dbConnection.Query(&models, query)

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query depends on a [user-provided value](1).
@prakash100198 prakash100198 changed the base branch from main to develop September 17, 2024 14:05
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@prakash100198 prakash100198 changed the title fix: Dependabot fixes 17sept chore: Dependabot fixes 17sept Sep 23, 2024
@prakash100198 prakash100198 merged commit 246c8cf into develop Sep 23, 2024
4 of 5 checks passed
@prakash100198 prakash100198 deleted the dependabot-fixes-17sept branch September 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants