Skip to content

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Sep 16, 2024

Description

Currently we do not show any errors on UI in case helm app deployment fails for both Helm and ArgoCD (sync/async) installed. This creates the following limitations:

  • Bad user experience, while deployment (asynchronous). Not enough visibility of what happened in the background.
  • No scope for the users to debug why the previous deployments have failed

This PR will support to display deployment failed message for Helm Apps and External Helm Apps

Fixes #5154, https://github.com/devtron-labs/sprint-tasks/issues/905

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

@Ash-exp Ash-exp merged commit 85710ec into develop Sep 18, 2024
@Ash-exp Ash-exp deleted the feat-deployment-status-msg branch September 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: We do not show any errors on UI in case helm app deployment fails

4 participants