Skip to content

feat: add support for tag name for external CI #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 3, 2024
Merged

feat: add support for tag name for external CI #5689

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8dcaaf3
remove validation that url exists in external artifact
ayu-devtron Aug 14, 2024
1883374
Merge branch 'develop' of github.com:devtron-labs/devtron into extern…
ayu-devtron Aug 28, 2024
348e9f3
handle docker tag name regex validation
ayu-devtron Aug 28, 2024
90db7e7
Merge branch 'develop' of github.com:devtron-labs/devtron into extern…
ayu-devtron Sep 2, 2024
fd6244b
sync with enterprise
prkhrkat Sep 2, 2024
15ca2b7
sync with enterprise
prkhrkat Sep 2, 2024
d87ec31
added validation for external ci tag name
ayu-devtron Sep 2, 2024
55b40d9
fix log
ayu-devtron Sep 2, 2024
9d53e3a
mark deployment aborted if validation fails
ayu-devtron Sep 2, 2024
22f0544
digest validation added
prkhrkat Sep 3, 2024
381360e
fix typo
ayu-devtron Sep 3, 2024
07ee82d
Merge branch 'develop' of github.com:devtron-labs/devtron into extern…
ayu-devtron Sep 3, 2024
f6e6648
common lib update
ayu-devtron Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pkg/pipeline/CiService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,6 @@ func (impl *CiServiceImpl) TriggerCiPipeline(trigger types.Trigger) (int, error)

// checking if user has given run time parameters for externalCiArtifact, if given then sending git material to Ci-Runner
externalCiArtifact, exists := trigger.ExtraEnvironmentVariables["externalCiArtifact"]
// validate externalCiArtifact as docker image
if exists {
if !strings.Contains(externalCiArtifact, ":") {
impl.Logger.Errorw("validation error", "externalCiArtifact", externalCiArtifact)
return 0, fmt.Errorf("invalid image name given in externalCiArtifact")
}
}
if trigger.PipelineType == string(CiPipeline.CI_JOB) && len(ciMaterials) != 0 && !exists && externalCiArtifact == "" {
ciMaterials = []*pipelineConfig.CiPipelineMaterial{ciMaterials[0]}
ciMaterials[0].GitMaterial = nil
Expand Down