Skip to content

fix: K8s Resource list RBAC ignore for Superadmin #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix: K8s Resource list RBAC ignore for Superadmin #5415

merged 2 commits into from
Jul 5, 2024

Conversation

@kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Jul 2, 2024 •
edited
Loading

Description

Fixes: #5417

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kripanshdevtron kripanshdevtron force-pushed the k8s-resource-list-optimization branch 2 times, most recently from 3005779 to 1cb6447 Compare July 3, 2024 06:41
gireesh-naidu
gireesh-naidu reviewed Jul 3, 2024
View reviewed changes
gireesh-naidu
gireesh-naidu reviewed Jul 3, 2024
View reviewed changes
@kripanshdevtron kripanshdevtron changed the title Perf: K8s Resource List RBAC ignore for Superadmin Perf: K8s Resource list RBAC ignore for Superadmin Jul 4, 2024
@kripanshdevtron kripanshdevtron force-pushed the k8s-resource-list-optimization branch from 7960129 to 71d4bca Compare July 5, 2024 07:48
@kripanshdevtron kripanshdevtron changed the title Perf: K8s Resource list RBAC ignore for Superadmin fix: K8s Resource list RBAC ignore for Superadmin Jul 5, 2024
@kripanshdevtron kripanshdevtron merged commit bd3beb8 into main Jul 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kripanshdevtron kripanshdevtron deleted the k8s-resource-list-optimization branch July 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d

+1 more reviewer

@gireesh-naidu gireesh-naidu gireesh-naidu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Explicit RBAC checks not required for Super-admins

4 participants

@kripanshdevtron @vikramdevtron @gireesh-naidu