Skip to content

fix: panic issue in get/ download pod logs api #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: panic issue in get/ download pod logs api #5342

merged 2 commits into from
Jun 25, 2024

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jun 20, 2024 •
edited
Loading

Description

fixed panic error on get/ download pod logs api

Fixes #5346

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp added the enhancement New feature or request label Jun 20, 2024
@Ash-exp Ash-exp self-assigned this Jun 20, 2024
@Ash-exp Ash-exp force-pushed the fix-panic-pod-log-api branch 3 times, most recently from 42b5704 to 6ac0d3c Compare June 21, 2024 06:57
@Ash-exp Ash-exp force-pushed the fix-panic-pod-log-api branch from 6ac0d3c to 832fadb Compare June 21, 2024 07:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit 3d559fa into main Jun 25, 2024
@Ash-exp Ash-exp deleted the fix-panic-pod-log-api branch June 25, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ash-exp Ash-exp

Labels

enhancement New feature or request PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: panic issue in get/ download pod logs api for invalid resource request

3 participants

@Ash-exp @nishant-d