Skip to content

Conversation

@ashoknayak777
Copy link
Contributor

@ashoknayak777 ashoknayak777 commented May 29, 2024

Main Changes

  • Added enhancements to application-level scanning (image scan, code scan, manifest scan)
  • Connected helm chart scanning too
  • Included gifs for better understanding

Adhoc Changes

  • Fixed broken links in glossary and application groups
  • Added a redirection from old cluster doc to resource browser doc

@ashoknayak777 ashoknayak777 self-assigned this May 29, 2024
@ashoknayak777 ashoknayak777 added the documentation Improvements or additions to documentation label May 29, 2024
@ashoknayak777 ashoknayak777 requested a review from abhibhaw May 29, 2024 14:45
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing scanning of kubernetes resources / cluster scanning etc. Entrypoints:

  • Resource browser
  • K8s resources on app details

@ashoknayak777
Copy link
Contributor Author

Missing scanning of kubernetes resources / cluster scanning etc. Entrypoints:

  • Resource browser
  • K8s resources on app details

Added the above entry-points in the doc

@ashoknayak777 ashoknayak777 requested a review from abhibhaw June 4, 2024 11:08
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashoknayak777 ashoknayak777 merged commit b456bcc into main Jun 6, 2024
@ashoknayak777 ashoknayak777 deleted the enhanced-scanning-doc branch June 6, 2024 09:57
Ash-exp added a commit that referenced this pull request Jun 10, 2024
* feat: replace user_deployment_request.status with pipeline_status_timelines

* updated schema migration script

* fix: migration script

* update readme to include multi arch flag (#4998)

* updated trigger event func and timeline names

* review comment incorporation

* fix: GetAllInCompleteRequests query

* fix: GetAllInCompleteRequests query

* fixed: UpdatePreviousQueuedRunnerStatus error

* fix: loogers

* doc: Added enhancements to security doc (#5203)

* Rough Draft Initiated

* Created Security Enhancement Docs + Other Adhoc Fixes

* Incorporated PM Feedback

* Modified Portforward Section to Kubectl Section (#5236)

* feat: cd pipeline deployment history refactoring (#5200)

* searchableKey service move

* migrated cd deployment history code

* idempotency of triggerPipeline func and minor fixes

* timeline fixes

* updated: NewTriggerEvent func

* updated ErrorDeploymentSuperseded err handling

* updated: GetArgoPipelinesHavingLatestTriggerStuckInNonTerminalStatuses statuses

* fix: timeline status

* refactored: UpdatePreviousQueuedRunnerStatus

* fix: GetPreviousQueuedRunners query

* fix: UpdateRunnerStatusToFailedForIds query

* fix: buildTriggerEventForOverrideRequest func

* fix: UpdateRunnerStatusToFailedForIds query

* fix: UpdateRunnerStatusToFailedForIds query

* updated: handleAsyncTriggerReleaseError func

* fix: concurrent case handlings

* updated folder name

* updated GetLastStatusPublishedTimeForWfrId func

* feat: removed audit timeline and error handlings

* fix: FetchTimelinesForWfrIdExcludingStatuses query

* fix: deleted pipeline flow

* timeline handling

* timeline handling fixed

* removed unused const

* chore: updated go-bitbucket version

* removed unnecessary alais

---------

Co-authored-by: ayu-devtron <[email protected]>
Co-authored-by: ashokdevtron <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Ash-exp added a commit that referenced this pull request Jun 19, 2024
* chore: context refactoring for gitops async

* chore: refactored context for argo app deploy operations

* tracer refactoring wip

* fixed: timeline status update issue and added force sync param - WIP

* fixed: undeclared varibale

* env gen updated

* common-lib version updated

* async deployment gitops and CEL expression

* chore: cel library added

* chore: go mod tidy

* feat: Async gitops deployment flow

* updated trigger pipeline scope

* triggerPipeline refactoring

* runner status update

* udpated pipelineOverride object in GetValuesOverrideForTrigger

* updated UserDeploymentRequest status

* cron method: incomplete deployment request

* updated alias naming

* updated alias naming

* updated go-bitbucket librabry

* added github.com/ash-exp/go-bitbucket

* chore: refactoring

* added migration script

* self review fixes - wip

* chore: ProcessIncompleteDeploymentReq updated

* updated migration and added util test cases

* updated test file name

* fix: trigger history audit step

* fix: status update for trigger audit

* chore: tracer refactoring

* removed comment

* removed duplicate status updates

* added NATS graceful shutdown

* fixed wire injection issue

* fixed: migration issues

* fix: deployment status update

* fix: nil UserDeploymentRequest model on save

* fix: UserDeploymentRequestRepositoryImpl.FindByCdWfIds nil model

* udpated validateStatusUpdate for user  deployment request

* removed duplicate flag

* fix: nil pointer in logger

* updated save userDeploymentRequest func

* updated save userDeploymentRequest func

* udpated: extractAsyncCdDeployRequestFromEventMsg

* fix: handled panic issues

* updated MarkCurrentDeploymentFailed func

* added tracer

* fix: unauthorized on async deployment

* fixed: updateTriggerEventForIncompleteRequest

* fixed envOverride.Environment data

* updateTriggerEventForIncompleteRequest for no gitops deployment types

* updated CreateHistoriesForDeploymentTrigger

* fix: updated history status

* fix: create history error

* fix: UpdateStatusForCdWfIds

* nil pointer check fix

* wire gen file

* removed unnecessary loggers

* fix: logger type

* create cm/cs history in transaction

* wirer gen file

* fix: nil pointer handling

* fix: TerminateForPipelineId func

* fix: UserDeploymentRequest db struct

* updated UpdateCDWorkflowRunnerStatus func

* fix: logger noise from markImageScanDeployed

* updated auto trigger loggers and ProcessConcurrentAsyncDeploymentReq context

* refactored: saveDeploymentTriggerHistory

* refactored: trigger async release

* fix: GetAllInCompleteRequests query

* fix: UNABLE_TO_FETCH timeline handling

* fix: async deployment request lock

* feat: gitops async with timeline (#5286)

* feat: replace user_deployment_request.status with pipeline_status_timelines

* updated schema migration script

* fix: migration script

* update readme to include multi arch flag (#4998)

* updated trigger event func and timeline names

* review comment incorporation

* fix: GetAllInCompleteRequests query

* fix: GetAllInCompleteRequests query

* fixed: UpdatePreviousQueuedRunnerStatus error

* fix: loogers

* doc: Added enhancements to security doc (#5203)

* Rough Draft Initiated

* Created Security Enhancement Docs + Other Adhoc Fixes

* Incorporated PM Feedback

* Modified Portforward Section to Kubectl Section (#5236)

* feat: cd pipeline deployment history refactoring (#5200)

* searchableKey service move

* migrated cd deployment history code

* idempotency of triggerPipeline func and minor fixes

* timeline fixes

* updated: NewTriggerEvent func

* updated ErrorDeploymentSuperseded err handling

* updated: GetArgoPipelinesHavingLatestTriggerStuckInNonTerminalStatuses statuses

* fix: timeline status

* refactored: UpdatePreviousQueuedRunnerStatus

* fix: GetPreviousQueuedRunners query

* fix: UpdateRunnerStatusToFailedForIds query

* fix: buildTriggerEventForOverrideRequest func

* fix: UpdateRunnerStatusToFailedForIds query

* fix: UpdateRunnerStatusToFailedForIds query

* updated: handleAsyncTriggerReleaseError func

* fix: concurrent case handlings

* updated folder name

* updated GetLastStatusPublishedTimeForWfrId func

* feat: removed audit timeline and error handlings

* fix: FetchTimelinesForWfrIdExcludingStatuses query

* fix: deleted pipeline flow

* timeline handling

* timeline handling fixed

* removed unused const

* chore: updated go-bitbucket version

* removed unnecessary alais

---------

Co-authored-by: ayu-devtron <[email protected]>
Co-authored-by: ashokdevtron <[email protected]>
Co-authored-by: kartik-579 <[email protected]>

* main branch merge

* vendor files updated

* udpated migration number

* fix: build issues

* chore: updated migration number

* fix: context canceling issue

* feat: git commit retry

* updated migration number

* fix: bitbucket git commit issue

* feat: env varibales for retry count and delay

* migration script updated

---------

Co-authored-by: ayu-devtron <[email protected]>
Co-authored-by: ashokdevtron <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants