Skip to content

Conversation

@kamal-devtron
Copy link
Contributor

@kamal-devtron kamal-devtron commented Apr 15, 2024

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented Apr 15, 2024

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret 4753231 devtron-images.txt.source View secret
10220829 Triggered Generic High Entropy Secret 279da7f charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 279da7f charts/devtron/devtron-bom.yaml View secret
9257608 Triggered Base64 AWS keys 78febd9 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 024d62a scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret b5ef536 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 78febd9 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 14d998f scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 78febd9 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret b5ef536 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret 14d998f scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret 024d62a scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

{{- if $.Values.topologySpreadConstraint }}
topologySpreadConstraints:
{{ toYaml .Values.topologySpreadConstraint }}
{{- end }}

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this Service Account to RBAC or disable "automountServiceAccountToken". See more on SonarCloud
@rupinSec
Copy link
Contributor

rupinSec commented Oct 3, 2024

updated changes related to envoy readiness, liveness and external secret are reviewed and tested.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants