-
Notifications
You must be signed in to change notification settings - Fork 554
feat: Refrence chart 4.19 added #4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10220829 | Triggered | Generic High Entropy Secret | 4753231 | devtron-images.txt.source | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | 279da7f | charts/devtron/values.yaml | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | 279da7f | charts/devtron/devtron-bom.yaml | View secret |
| 9257608 | Triggered | Base64 AWS keys | 78febd9 | scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 024d62a | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | b5ef536 | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 78febd9 | scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 14d998f | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 78febd9 | scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | b5ef536 | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 14d998f | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 024d62a | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
|
scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/templates/deployment.yaml
Fixed
Show fixed
Hide fixed
scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/templates/deployment.yaml
Fixed
Show fixed
Hide fixed
|
383505b to
caf293d
Compare
570ec5a to
500ea25
Compare
51368df to
8947ea2
Compare
9eb4ecd to
67f7322
Compare
| {{- if $.Values.topologySpreadConstraint }} | ||
| topologySpreadConstraints: | ||
| {{ toYaml .Values.topologySpreadConstraint }} | ||
| {{- end }} |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium
8c5d667 to
d2a6706
Compare
c980e20 to
279da7f
Compare
|
updated changes related to envoy readiness, liveness and external secret are reviewed and tested. |
|








Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?