fix:job name support added in input variables #4863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laeeqdev
requested review from
kripanshdevtron,
nishant-d and
vikramdevtron
as code owners
prakash100198
requested changes
Apr 1, 2024
prakash100198
requested changes
Apr 2, 2024
prakash100198
approved these changes
Apr 2, 2024
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
kripanshdevtron
approved these changes
Apr 9, 2024
prakash100198
approved these changes
Apr 9, 2024
Laeeqdev
changed the title
|
komalreddy3
pushed a commit
that referenced
this pull request
May 28, 2024
* job name added * resolved PR code review comments * resolved PR code review comments final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue of incorrect variable naming in the job task has been resolved. Previously, the input variable was mistakenly labeled as "app_name" instead of the correct "job_name," also printing wrong value of app_name. Through the fix, the variable naming has been adjusted to accurately reflect the intended functionality, ensuring the correct values are now displayed as expected in the task output
Fixes #4867
Checklist:
Does this PR introduce a user-facing change?