feat: Add support for git hash in the app and app group overview section #4815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p and App Group Overview page (#4811) * Added OpenApi specs for the global plugins * Updated the Global-Plugin Specs for Patch Request handling * Fixes the GlobalPlugin PatchPlugin request * Fixes the GlobalPlugin PatchPlugin request modified * removed the commented code of the GlobalPlugin PatchPlugin filtering * Added the service of getting the Githash in the app overview and App group overview * Modified the unnecesaary code in the service layer of getting the Githash in the app overview and App group overview
RajeevRanjan27
requested review from
kripanshdevtron,
nishant-d and
vikramdevtron
as code owners
RajeevRanjan27
changed the title
| Type string `json:"type"` | ||
| AppId int `json:"appId"` | ||
| } | ||
| type CiArtifactWithParentArtifact struct { |
There was a problem hiding this comment.
This should move at some common place
nishant-d
suggested changes
Mar 26, 2024
pkg/app/AppListingService.go
Outdated
| if _, ok := artifactChildParentMap[artifact.CiArtifactId]; ok { | ||
| ciArtifactIds = []int{artifactChildParentMap[artifact.CiArtifactId]} | ||
| } | ||
| } else if !slices.Contains(ciArtifactIds, artifactChildParentMap[artifact.CiArtifactId]) { |
There was a problem hiding this comment.
Contains is a linear search, invoking inside for loop will make complexity exponential.
There was a problem hiding this comment.
resolved using map
pkg/app/AppListingService.go
Outdated
| } | ||
|
|
||
| gitCommits, exists := gitCommitsWithArtifacts[env.CiArtifactId] | ||
| if exists { |
There was a problem hiding this comment.
rewrite it for only one assignment and one initialisation
| @@ -0,0 +1,615 @@ | |||
| openapi: "3.0.3" | |||
|
|
this pr has been resolved in pr reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This include feature of getting the githash of artifacts deployed fot that app in app overview environment section
Also the same feature is there in the app group overview section too as requested.
Fixes #4797
Checklist:
Does this PR introduce a user-facing change?