Skip to content

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Feb 28, 2024

Description

Issues Fixed:

  • Deploy any chart via argo cd ->deployment status stuck in progress
    • It was caused by git CLI as we are storing the shortened git hash in the database; which fails to match in deployment status update flow.
    • It is impacting helm apps install flow only as we perform that flow using git cli instead of (provider based APIs)

Fixes #4727

How Has This Been Tested?

  • Helm Apps Install flow with GitOps deployment

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikramdevtron vikramdevtron merged commit 9e7e9c3 into main Feb 29, 2024
@vikramdevtron vikramdevtron deleted the 28feb-packet-common-bug-fix branch February 29, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Multiple packet testing issues

6 participants