Skip to content

Conversation

@iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Jan 8, 2024

Description

Fixes #4416

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented Jan 8, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
9257608 Base64 AWS keys 828c38e scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json View secret
9044201 Generic High Entropy Secret 26392d6 client/argocdServer/k8sClient.go View secret
9044201 Generic High Entropy Secret 94f1e6f client/argocdServer/k8sClient.go View secret
2763127 Generic High Entropy Secret 828c38e scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Generic High Entropy Secret 828c38e scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml View secret
141558 Generic High Entropy Secret 828c38e scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml View secret
141558 Generic High Entropy Secret 828c38e scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions
Copy link

Error: The SQL file number: 207 is duplicated

@github-actions
Copy link

Error: The SQL file number: 207 is duplicated

@github-actions
Copy link

Error: The SQL file number: 207 is duplicated

@github-actions
Copy link

Error: The SQL file number: 207 is duplicated

@github-actions
Copy link

Error: The SQL file number: 207 is duplicated

nishant-d
nishant-d previously approved these changes Jan 25, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shivani170 shivani170 merged commit 9bd59a2 into main Jan 29, 2024
@shivani170 shivani170 deleted the pulling-image-with-digest branch January 29, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Support overriding DOCKER_IMAGE_TAG with TAG@DIGEST for deployments

5 participants