Skip to content

Conversation

@ashoknayak777
Copy link
Contributor

@ashoknayak777 ashoknayak777 commented Jan 4, 2024

Completed:

  • Workflow updated with snapshots
  • CI document restructured and updated (Image Tag included)
  • CD document restructured and updated (Tag and Approval included)
  • Copy Container Image plugin added (Skopeo)
  • RBAC
  • Image Digest at CD included and GC added

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashoknayak777 ashoknayak777 changed the title Revamp approvaldoc docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag at CD Jan 4, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to include latest images having digest options as well. And maybe we can handle that too with this. Also we need to give some ideal pipelines (Devtron recommended) with this doc

Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

@ashoknayak777 ashoknayak777 changed the title docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag at CD docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag + Image Digest at CD Feb 13, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the content is great, and we have covered all the topics in detail, one concern I have is repetition. A lot of same / similar content in repeated this will make it harder for us to manage and for users it may be confusing as while I was reading every time it was in my mind I think I read this few lines above.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashoknayak777 ashoknayak777 dismissed abhibhaw’s stale review February 23, 2024 14:05

Changes have been incorporated

@ashoknayak777 ashoknayak777 merged commit 63741cb into main Feb 23, 2024
@ashoknayak777 ashoknayak777 deleted the revamp-approvaldoc branch February 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants