Skip to content

fix: added missing clusterConfig in releaseIdentifier request #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix: added missing clusterConfig in releaseIdentifier request #4359

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c741a9d
added missing clusterConfig in releaseIdentifier request
gireesh-naidu Dec 6, 2023
24b115d
remove duplicate logic
gireesh-naidu Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/appStore/deployment/service/InstalledAppService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,14 @@ func (impl *InstalledAppServiceImpl) FindNotesForArgoApplication(installedAppId,
},
}

clusterId := installedAppVerison.InstalledApp.Environment.ClusterId
config, err := impl.helmAppService.GetClusterConf(clusterId)
if err != nil {
impl.logger.Errorw("error in fetching cluster detail", "clusterId", clusterId, "err", err)
return "", appName, err
}
installReleaseRequest.ReleaseIdentifier.ClusterConfig = config

notes, err = impl.helmAppService.GetNotes(context.Background(), installReleaseRequest)
if err != nil {
impl.logger.Errorw("error in fetching notes", "err", err)
Expand Down