Skip to content

feat: Enable Notification for Protect Configuration Approval request #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat: Enable Notification for Protect Configuration Approval request #4358

merged 1 commit into from
Dec 6, 2023

Conversation

@adi6859
Copy link
Contributor

@adi6859 adi6859 commented Dec 6, 2023 •
edited by badal773
Loading

Description

  • Enable Notification for Protect Configuration Approval request.

Fixes #4231

How Has This Been Tested?

All test are performed locally

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adi6859 adi6859 merged commit 33da69b into main Dec 6, 2023
@adi6859 adi6859 deleted the protect-config-mig branch December 6, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d

1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Enable Notification for Protect Configuration Approval .

3 participants

@adi6859 @kripanshdevtron