Skip to content

fix: not able to add env in global configuration #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: not able to add env in global configuration #4330

merged 1 commit into from
Dec 1, 2023

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Dec 1, 2023 •
edited
Loading

Description

Updated the sql query used in validating whether the namespace exists or not. Namespace is unique across a specific cluster and Environment name is unique across all cluster.

Fixes #4329

How Has This Been Tested?

  • env across cluster should be unique
  • namespace cannot be same within a cluster
  • namespace can be same across cluster

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp added the enhancement New feature or request label Dec 1, 2023
@Ash-exp Ash-exp requested a review from iamayushm December 1, 2023 11:54
@Ash-exp Ash-exp self-assigned this Dec 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nishant-d nishant-d merged commit bb575b5 into main Dec 1, 2023
@nishant-d nishant-d deleted the fix-namespace-create-err branch December 1, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamayushm iamayushm iamayushm approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

+1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ash-exp Ash-exp

Labels

enhancement New feature or request PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: not able to add env in global configuration

4 participants

@Ash-exp @iamayushm @nishant-d