Skip to content

fix: updated copy container image plugin for multi arc build support #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: updated copy container image plugin for multi arc build support #4282

merged 1 commit into from
Nov 24, 2023

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Nov 24, 2023 •
edited
Loading

Description

fix: Added multi arc build support to copy container image plugin
Changes in Plugin Repo: devtron-labs/copy-container-images-plugin@7c76e5f

Fixes #4283

How Has This Been Tested?

  • Build and Trigger CI with Multi Arc build
  • Copy the Image form Private to Public repo a multi arc image
  • Copy the Image form Private to Private repo a multi arc image
  • Trigger copy image for same artifact in parallel

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp added the enhancement New feature or request label Nov 24, 2023
@Ash-exp Ash-exp requested a review from iamayushm November 24, 2023 08:55
@Ash-exp Ash-exp self-assigned this Nov 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iamayushm iamayushm merged commit 6e5e364 into main Nov 24, 2023
@iamayushm iamayushm deleted the fix-copy-container-images-multi-arc branch November 24, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamayushm iamayushm iamayushm approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d

Assignees

@Ash-exp Ash-exp

Labels

enhancement New feature or request PR:Issue-verification-failed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Copy Container Image plugin is not working for multi arc builds

4 participants

@Ash-exp @iamayushm @vikramdevtron