chore: change CI backend infra #4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne except externalwebhook
Comment on lines
1323
to
1324
| // find any builds running on old ci_pipeline, if yes block this conversion with proper message. | ||
| inProgressWorkflows, err := impl.ciWorkflowRepository.FindRunningWorkflowCount(switchFromCiPipelineId) |
There was a problem hiding this comment.
we should check for recent one's only, there might be a possibility that we would find some old Running workflows
|
|
||
| return nil | ||
| } | ||
| func (impl *CiPipelineConfigServiceImpl) deleteCiPipeline(tx *pg.Tx, ciPipeline *pipelineConfig.CiPipeline, externalCiPipelineId int, userId int32) error { |
There was a problem hiding this comment.
func name should convey the the logic. renaming is required
| } | ||
|
|
||
| if request.IsSwitchCiPipelineRequest() { | ||
| impl.logger.Debugw("handling switch ci pipeline") |
There was a problem hiding this comment.
Improve logging here.
| return impl.handleSwitchCiPipeline(request, ciConfig) | ||
| } | ||
|
|
||
| impl.logger.Debugw("create patch request") |
There was a problem hiding this comment.
improve logging here.
| return nil, err | ||
| } | ||
|
|
||
| impl.logger.Debugw("create patch request for ci switch") |
There was a problem hiding this comment.
Improve logging here
| return originalCiConf, nil | ||
| } | ||
|
|
||
| func (impl *CiPipelineConfigServiceImpl) validateCiPipelineSwitch(switchFromCiPipelineId int, switchFromExternalCiPipelineId int, switchToType, switchFromType bean.PipelineType) error { |
There was a problem hiding this comment.
we can make PipelineSwitchHandler and move switch logic to that place.
CC: @subhashish-devtron
# Conflicts: # wire_gen.go
|
Kudos, SonarCloud Quality Gate passed!
|
subhashish-devtron
changed the title
subhashish-devtron
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
subhashish-devtron
changed the title
kripanshdevtron
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
code changes for setting infra in backend for change CI feature
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?