Skip to content

fix: deleted service showing port as missing fix #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2023
Merged

fix: deleted service showing port as missing fix #4240

merged 3 commits into from
Nov 17, 2023

Conversation

@prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Nov 14, 2023 •
edited
Loading

Description

This pr contains the fix for, when a service is deleted all it's children are deleted but the port mentioned in the manifest is also showing as missing which is a wrong info, the port should be visible.
Fixes #4241

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakash100198 prakash100198 merged commit 92fbb5d into main Nov 17, 2023
@prakash100198 prakash100198 deleted the deleted-service-port-fix branch November 17, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d

+1 more reviewer

@subhashish-devtron subhashish-devtron subhashish-devtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: After deleting the services, URL is not getting deleted(chatstore/helm) and if deleted in other cases gives wrong message "port number is missing".

4 participants

@prakash100198 @vikramdevtron @subhashish-devtron