feat: copy container images #4209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ciPipeline, err := handler.ciPipelineRepository.GetCiPipelineByArtifactId(artifactId) | ||
| var externalCiPipeline *pipelineConfig.ExternalCiPipeline | ||
| ciArtifact, err := handler.ciArtifactRepository.Get(artifactId) |
There was a problem hiding this comment.
all this below code can be part of service
| handler.Logger.Errorw("Error in fetching ci artifact by ci artifact id", "err", err) | ||
| return externalCi, ciPipelineId, appId, err | ||
| } | ||
| if ciArtifact.DataSource == repository.POST_CI { |
There was a problem hiding this comment.
comment down all the probable DataSource in model
| Methods("GET"). | ||
| HandlerFunc(r.handler.ManagedResources) | ||
| router.Path("/{name}/rollback"). | ||
| router.Path("/{name}" + |
| } | ||
|
|
||
| commonQuery = fmt.Sprintf(commonQuery, listingFilterOptions.PipelineId, listingFilterOptions.StageType, listingFilterOptions.ParentId, listingFilterOptions.ParentStageType, listingFilterOptions.SearchString) | ||
| commonQuery := " from ci_artifact LEFT JOIN cd_workflow ON ci_artifact.id = cd_workflow.ci_artifact_id" + |
There was a problem hiding this comment.
describe in comment what results we expects from this query
| " AND ((cd_workflow.pipeline_id= %v and cd_workflow_runner.workflow_type = '%v' ) OR (cd_workflow.pipeline_id = %v AND cd_workflow_runner.workflow_type = '%v' AND cd_workflow_runner.status IN ('Healthy','Succeeded') )))" + | ||
| " OR (ci_artifact.component_id = %v and ci_artifact.data_source= '%v' ))" + | ||
| " AND (ci_artifact.image LIKE '%v' )" | ||
| //commonQuery := " FROM cd_workflow_runner " + |
There was a problem hiding this comment.
remove commented code
pkg/pipeline/PipelineBuilder.go
Outdated
|
|
||
| func parseMaterialInfo(materialInfo json.RawMessage, source string) (json.RawMessage, error) { | ||
| if source != "GOCD" && source != "CI-RUNNER" && source != "EXTERNAL" { | ||
| if source != "GOCD" && source != "CI-RUNNER" && source != "EXTERNAL" && source != "pre_cd" && source != "post_cd" && source != "post_ci" { |
| destinationRegistryRepoDetails := strings.Split(destinationInfo, "\n") | ||
| for _, detail := range destinationRegistryRepoDetails { | ||
| registryRepoSplit := strings.Split(detail, "|") | ||
| registryName := strings.Trim(registryRepoSplit[0], " ") |
There was a problem hiding this comment.
use EmptyString Constaint
scripts/sql/190_custom_tag.down.sql
Outdated
| @@ -0,0 +1,7 @@ | |||
| ALTER TABLE custom_tag DROP COLUMN enabled; | |||
| ALTER TABLE ci_artifact DROP COLUMN credentials_source_type ; | |||
There was a problem hiding this comment.
Use single seq file for the release
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
vikramdevtron
previously approved these changes
Nov 20, 2023
vikramdevtron
previously approved these changes
Nov 21, 2023
vikramdevtron
previously approved these changes
Nov 21, 2023
|
SonarCloud Quality Gate failed.
|
vikramdevtron
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4259
#3521
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?