Skip to content

feat: scoped variable CMCS support and manager layer refactorings #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 97 commits into from
Nov 2, 2023
Merged

feat: scoped variable CMCS support and manager layer refactorings #4174

merged 97 commits into from
Nov 2, 2023

Conversation

@subhashish-devtron
Copy link
Contributor

@subhashish-devtron subhashish-devtron commented Oct 30, 2023 •
edited
Loading

Description

Fixes #3917
scoped variable CMCS support and manager layer refactorings

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

subhashish-devtron and others added 30 commits October 9, 2023 13:57
@subhashish-devtron
app name
cf7a9cc
@subhashish-devtron
image tag
2d0fa09
@subhashish-devtron
refactoring - move to oss
3fcbdb7
@subhashish-devtron
WIP
85d07c6
@subhashish-devtron
added resolved template in API response
695c10f
@subhashish-devtron
Merge branch 'main' into system-appname
d56801d 
# Conflicts:
#	pkg/resourceQualifiers/bean.go
#	pkg/resourceQualifiers/constants.go
@subhashish-devtron
reverting regex changes
2cd1644
@subhashish-devtron
wip
d439d30
@subhashish-devtron
cleaned comments
17e0116
@subhashish-devtron
test commit
de38792
@subhashish-devtron
fix
ec09062
@subhashish-devtron
fix env for specific deployment
d4e21a4
@subhashish-devtron
snapshot fixes for deployment
366e938
@subhashish-devtron
Merge branch 'main' into system-appname
1e8659f
@subhashish-devtron
fix
3888ca1
@subhashish-devtron
Merge branch 'main' into system-appname
bb72bf9
@subhashish-devtron
sensitive variable masking in all flows
1a79baa
@subhashish-devtron
removed dead comments
d4b96ed
@subhashish-devtron
validation for non-string sensitive
57f8819
@subhashish-devtron
Merge branch 'main' into system-appname
f7ead31
@adi6859
TODO COMMIT
1f083f5
@subhashish-devtron
Merge branch 'main' into system-appname
02432b5
@adi6859
scoped variable support added for add/update for cm/cs
cc8f27d
@adi6859
support added for trigger
0315175
@adi6859
extra function call removed
c5e88b1
@subhashish-devtron
addressed comments
2158eff
@subhashish-devtron
Merge branch 'main' into system-appname
c025ca7
@adi6859
env variable code commented and issue fixing
e63fb02
@subhashish-devtron
commit minor fix
a5e061c
@adi6859
Merge branch 'System-appname' into System-appname-CMCS
b1dffde
@subhashish-devtron subhashish-devtron changed the title Manager refactor feat: scoped variable CMCS support and manager layer refactorings Nov 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@subhashish-devtron subhashish-devtron merged commit d82cdcb into main Nov 2, 2023
@subhashish-devtron subhashish-devtron deleted the manager-refactor branch November 2, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d

1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Variables support

4 participants

@subhashish-devtron @kripanshdevtron @adi6859