fix: Unable to delete ci pipeline in case you configure multi git #4072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashish-devtron
requested review from
kripanshdevtron,
nishant-d and
vikramdevtron
as code owners
github-actions
bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
kripanshdevtron
approved these changes
Oct 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
ShashwatDadhich
pushed a commit
that referenced
this pull request
Oct 12, 2023
* chore: moved k8s library to common-lib and added scripts for adding sshTunnel config to clusters (#3848) * added db scripts for cluster table * updated script * renamed script no * changed sql script * wip * updated dependency * wip * bumped common-lib-version * updated vendor * vendor files * updated sql script no. * added insecureTls connection param in kubelink requests * updated sql script no. * added argoproj assets * wip * added argoproj files * updated .gitignore * updated sql script no * updated sql script no * shifted common-lib to major version import * check for active ci_pipeline_material (#4072) --------- Co-authored-by: Ashish-devtron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It bugs out when you configure multi git application and delete one of the configured git repo.
While deleting the CiPipeline We are try to get the deleted pipeline materials and throws error.
Fixes #4071
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?