Skip to content

chore: refactoring around PipelineBuilder #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2023
Merged

chore: refactoring around PipelineBuilder #4043

merged 6 commits into from
Oct 10, 2023

Conversation

@adi6859
Copy link
Contributor

@adi6859 adi6859 commented Oct 9, 2023

Description

Refactoring is done around pipelineBuilder. All methods are moved to respective files and interface according to the use-cases.

How Has This Been Tested?

  • self review has been performed .
  • One method in each interface are tested.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@adi6859 adi6859 requested a review from pghildiyal October 9, 2023 11:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

No Coverage information No Coverage information
14.5% 14.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@adi6859 adi6859 merged commit 6742145 into main Oct 10, 2023
@adi6859 adi6859 deleted the pipeline-refac-2 branch October 10, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d

@pghildiyal pghildiyal Awaiting requested review from pghildiyal

1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adi6859 @kripanshdevtron