feat: Scoped variables primitive handling #4033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhashish-devtron
requested review from
kripanshdevtron,
nishant-d and
vikramdevtron
as code owners
| } | ||
|
|
||
| func preProcessPlaceholder(template string) string { | ||
| pattern := `\"@{{([^}]+)}}\"` |
There was a problem hiding this comment.
make a constant of this regex and why aren't we using our variable regex here ??
There was a problem hiding this comment.
have used the same regex now but since I'm using this regex to extract inner content I the regex I need is slightly different.
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
subhashish-devtron
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
nishant-d
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4011
Adds handling for primitives in variable parsing
adds support for system variables
How Has This Been Tested?
Tested on a cluster for various scenarios
Checklist:
Does this PR introduce a user-facing change?