Skip to content

chore: Scoped variable refactoring #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 29, 2023
Merged

chore: Scoped variable refactoring #3977

merged 18 commits into from
Sep 29, 2023

Conversation

@kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Sep 28, 2023 •
edited by gireesh-naidu
Loading

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

subhashish-devtron
subhashish-devtron reviewed Sep 28, 2023
View reviewed changes
@kripanshdevtron kripanshdevtron changed the title Scoped variable refactoring chore: Scoped variable refactoring Sep 29, 2023
@kripanshdevtron kripanshdevtron marked this pull request as ready for review September 29, 2023 13:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gireesh-naidu gireesh-naidu merged commit 3032b4b into main Sep 29, 2023
@gireesh-naidu gireesh-naidu deleted the scoped-variable-refactoring branch September 29, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d

+2 more reviewers

@gireesh-naidu gireesh-naidu gireesh-naidu approved these changes

@subhashish-devtron subhashish-devtron subhashish-devtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kripanshdevtron @vikramdevtron @gireesh-naidu @subhashish-devtron