Skip to content

feat: resource groups CRUD and environment filtering #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 30, 2023
Merged

feat: resource groups CRUD and environment filtering #3974

merged 19 commits into from
Sep 30, 2023

Conversation

@subhashish-devtron
Copy link
Contributor

@subhashish-devtron subhashish-devtron commented Sep 27, 2023 •
edited by vikramdevtron
Loading

Description

Fixes #3992

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

subhashish-devtron
subhashish-devtron commented Sep 27, 2023
View reviewed changes
prakash100198
prakash100198 requested changes Sep 27, 2023
View reviewed changes
@subhashish-devtron subhashish-devtron changed the title resource group feat: resource groups CRUD and environment filtering Sep 27, 2023
subhashish-devtron
subhashish-devtron commented Sep 28, 2023
View reviewed changes
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
10.7% 10.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kripanshdevtron kripanshdevtron merged commit b32607e into main Sep 30, 2023
@kripanshdevtron kripanshdevtron deleted the env-filter-final branch September 30, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakash100198 prakash100198 prakash100198 approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d

+1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Ability to apply environment filter in Devtron Applications

5 participants

@subhashish-devtron @prakash100198 @vikramdevtron @kripanshdevtron