Skip to content

feat: added env variable to skip gitops validation on create/update #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 25, 2023
Merged

feat: added env variable to skip gitops validation on create/update #3956

merged 5 commits into from
Sep 25, 2023

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Sep 22, 2023 •
edited
Loading

Description

Added an env variable to skip GitOps validation in Global configuration.

Fixes #3961

How Has This Been Tested?

  • GitHub

    • Save
    • Update
    • Validate

  • GitLab

    • Save
    • Update
    • Validate

  • Azure

    • Save
    • Update
    • Validate

  • Bitbucket

    • Save
    • Update
    • Validate

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp added the enhancement New feature or request label Sep 22, 2023
@Ash-exp Ash-exp self-assigned this Sep 22, 2023
vikramdevtron
vikramdevtron previously approved these changes Sep 22, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ash-exp Ash-exp merged commit cd1c4d3 into main Sep 25, 2023
@Ash-exp Ash-exp deleted the feat-skip-gitops-validation branch September 25, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@iamayushm iamayushm Awaiting requested review from iamayushm

Assignees

@Ash-exp Ash-exp

Labels

enhancement New feature or request PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Bypass Gitops validation while saving credentials for the creation of repo

4 participants

@Ash-exp @vikramdevtron @prakarsh-dt