feat: wf pod restart #3892
Merged
feat: wf pod restart #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/pipeline/CdHandler.go
Outdated
| } | ||
|
|
||
| if retryCnt >= impl.cdConfig.MaxCdWorkflowRunnerRetries { | ||
| impl.Logger.Debugw("maximum retries for this workflow are exhausted, not re-triggering again", "retries", retryCnt, "wfrId", runner.Id) |
There was a problem hiding this comment.
convert this to Info level msg
pkg/pipeline/CiHandler.go
Outdated
Comment on lines
1577
to
1588
| clusterConfig, err := cluster.GetClusterBean(*env.Cluster).GetClusterConfig() | ||
| if err != nil { | ||
| impl.Logger.Warnw("error in getting cluster Config", "err", err, "clusterId", env.Cluster.Id) | ||
| continue | ||
| } | ||
|
|
||
| client, err = impl.K8sUtil.GetCoreV1Client(clusterConfig) | ||
| if err != nil { | ||
| impl.Logger.Warnw("error in getting core v1 client using clusterConfig", "err", err, "clusterId", env.Cluster.Id) | ||
| continue | ||
| } | ||
| ns = env.Namespace |
There was a problem hiding this comment.
create separate func for this
pkg/pipeline/CiHandler.go
Outdated
| if ciWorkflow.Status != WorkflowCancel { | ||
| retryCount, refCiWorkflow, err := impl.getRefWorkflowAndCiRetryCount(ciWorkflow) | ||
| if err != nil { | ||
| impl.Logger.Errorw("error in getRefWorkflowAndCiRetryCount", "ciWorkflowId", ciWorkflow.Id) |
There was a problem hiding this comment.
error not logged here
|
|
||
| func (impl *CdWorkflowRepositoryImpl) FindRetriedWorkflowCountByReferenceId(wfrId int) (int, error) { | ||
| retryCount := 0 | ||
| query := fmt.Sprintf("select count(*) "+ |
There was a problem hiding this comment.
use id instead of * here
gireesh-naidu
requested review from
nishant-d and
vikramdevtron
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
kripanshdevtron
approved these changes
Oct 11, 2023
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature is to retrigger ci,pre-cd and post-cd workflows incase they get deleted before reaching terminal state.
Fixes #4061
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?