feat: Helm async install #3856
feat: Helm async install #3856
Conversation
| @@ -0,0 +1,3 @@ | |||
| alter table installed_app_version_history | |||
| add column helm_release_status_config text; | |||
There was a problem hiding this comment.
we can add description, that will help to understand this json for status config
| releaseStatus := util3.InterfaceToMapAdapter(detail.ReleaseStatus) | ||
| appDetailsContainer.ReleaseStatus = releaseStatus | ||
| impl.logger.Warnw("appName and envName not found - avoiding resource tree call", "app", installedApp.App.AppName, "env", installedApp.Environment.Name) | ||
| } else { |
There was a problem hiding this comment.
can we put this in separate function, functions should be very small.
| callback := func(msg *pubsub.PubSubMsg) { | ||
|
|
||
| impl.logger.Debug("received helm install status event") | ||
| impl.logger.Debugw("HELM_INSTALL_STATUS", "data", msg.Data) |
There was a problem hiding this comment.
put this log in previous line
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 2763127 | Generic High Entropy Secret | 39bfa39 | scripts/devtron-reference-helm-charts/statefulset-chart_5-0-0/secrets-test-values.yaml | View secret |
| 141558 | Generic High Entropy Secret | 39bfa39 | scripts/devtron-reference-helm-charts/statefulset-chart_5-0-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| } | ||
|
|
||
| err := impl.updateApplicationWithChartInfo(ctx, installAppVersionRequest.InstalledAppId, installAppVersionRequest.AppStoreVersion, installAppVersionRequest.ValuesOverrideYaml) | ||
| err := impl.updateApplicationWithChartInfo(ctx, installAppVersionRequest.InstalledAppId, installAppVersionRequest.AppStoreVersion, installAppVersionRequest.ValuesOverrideYaml, 0) |
There was a problem hiding this comment.
use Constant variable instead of passing 0
|
SonarCloud Quality Gate failed.
|
Description
Fixes #3482
This PR introduces following changes:-
To enable async operation set RUN_HELM_INSTALL_IN_ASYNC_MODE="true"
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?