Skip to content

fix: Makefile correction #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix: Makefile correction #3852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b2a290
GOFLAGS flag introduced in
prakash100198 Sep 1, 2023
2f8e161
ea makefile fix
prakash100198 Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ build: clean wire
-X 'github.com/devtron-labs/devtron/util.ServerMode=${SERVER_MODE_FULL}'"

wire:
export GOFLAGS=-buildvcs=false
Copy link
Contributor

@vikramdevtron vikramdevtron Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this backward compatible, will this work on prior releases than shallow clone

Copy link
Contributor Author

@prakash100198 prakash100198 Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's backward compatible

Copy link
Contributor

@vikramdevtron vikramdevtron Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

wire

clean:
rm -f devtron
rm -rf devtron

test-all: test-unit
echo 'test cases ran successfully'
Expand Down
3 changes: 2 additions & 1 deletion cmd/external-app/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ build: clean wire
-X 'github.com/devtron-labs/devtron/util.ServerMode=${SERVER_MODE_EA_ONLY}'"

wire:
export GOFLAGS=-buildvcs=false
wire

clean:
rm -f devtron-ea
rm -rf devtron-ea

run: build
./devtron-ea
Expand Down