feat: custom tag #3847
feat: custom tag #3847
Conversation
| EntityKey int `json:"entityKey"` | ||
| EntityValue string `json:"entityValue"` | ||
| TagPattern string `json:"tagPattern"` | ||
| AutoIncreasingNumber int `json:"counterX"` |
There was a problem hiding this comment.
can be used better name for counterX
pkg/CustomTagService.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| imagePathPattern = "%s/%s:%s" // dockerReg/dockerRepo:Tag |
There was a problem hiding this comment.
we can put these type of constants at some common place
pkg/CustomTagService.go
Outdated
| customTagData := repository.CustomTag{ | ||
| EntityKey: tag.EntityKey, | ||
| EntityValue: tag.EntityValue, | ||
| TagPattern: strings.ReplaceAll(tag.TagPattern, "{X}", "{x}"), |
There was a problem hiding this comment.
can we use some other relevant name than X
pkg/CustomTagService.go
Outdated
| if customTagData.AutoIncreasingNumber < 0 { | ||
| return "", fmt.Errorf("counter {x} can not be negative") | ||
| } | ||
| dockerImageTag := strings.ReplaceAll(customTagData.TagPattern, "{x}", strconv.Itoa(customTagData.AutoIncreasingNumber-1)) //-1 because number is already incremented, current value will be used next time |
pkg/CustomTagService.go
Outdated
|
|
||
| // for patterns like v1.0.{x} we will calculate count with . in {x} i.e .{x} | ||
| variableCount := 0 | ||
| variableCount = variableCount + strings.Count(customTagPattern, "{x}") |
There was a problem hiding this comment.
can we use some other placeholder everywhere for x
| } | ||
| err = impl.customTagService.DeactivateImagePathReservation(ciWorkflow.ImagePathReservationId) | ||
| if err != nil { | ||
| impl.Logger.Errorw("unable to update ci workflow, its eligible to mark failed", "err", err) |
There was a problem hiding this comment.
why not returning error
There was a problem hiding this comment.
there are more than one ci_workflows updated in this function. If there is some error with one workflow then we are skipping only that workflow and continuing our loop
| return err | ||
| } | ||
|
|
||
| go func() { |
There was a problem hiding this comment.
can use use nats for this purpose
|
Kudos, SonarCloud Quality Gate passed!
|
feat: custom tag
Fixes #3566
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?
Yes