feat: support for docker buildx k8s driver #3743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/pipeline/CiConfig.go
Outdated
| OrchestratorToken string `env:"ORCH_TOKEN" envDefault:""` | ||
| BuildXK8sDriverNamespace string `env:"BUILDX_K8S_DRIVER_NAMESPACE" envDefault:"devtron-ci"` | ||
| BuildxK8sDriverNodes string `env:"BUILDX_K8S_DRIVER_NODES"` | ||
| UseBuildxK8sDriver bool `env:"USE_BUILDX_K8S_DRIVER" envDefault:"false"` |
There was a problem hiding this comment.
can we derive this variable from BuildxK8sDriverNodes ??
pkg/pipeline/bean/CiBuildConfig.go
Outdated
| DockerBuildOptions map[string]string `json:"dockerBuildOptions,omitempty"` | ||
| BuildContext string `json:"buildContext,omitempty"` | ||
| UseBuildx bool `json:"useBuildx"` | ||
| UseBuildxK8sDriver bool `json:"useBuildxK8sDriver,omitempty"` |
There was a problem hiding this comment.
are we using k8s driver when no UseBuildxK8sDriver is passed ??
pkg/pipeline/bean/CiBuildConfig.go
Outdated
| BuildxK8sDriverOptions []BuildxK8sDriverOptions `json:"buildxK8SDriverOptions,omitempty"` | ||
| } | ||
|
|
||
| type BuildxK8sDriverOptions struct { |
There was a problem hiding this comment.
can we make this generic map, so that if anyone wants to pass new Param, can add that ??
kripanshdevtron
previously approved these changes
Aug 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
kripanshdevtron
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added support for docker buildx driver
Fixes #3765
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?