Skip to content

fix: Showing port number instead of string port_number. #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 11, 2023
Merged

fix: Showing port number instead of string port_number. #3729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6bb2acb
port array handling
dhananjay0601 Aug 3, 2023
edfd1b2
Merge branch 'main' into port_number_placeholder
dhananjay0601 Aug 3, 2023
1a6751e
port-number handling for argoCD app
dhananjay0601 Aug 7, 2023
df92b2f
removal of commented code
dhananjay0601 Aug 7, 2023
f548a8e
EndpointSlice
dhananjay0601 Aug 7, 2023
d00ad4f
array handling
dhananjay0601 Aug 7, 2023
37b298b
code refactoring
dhananjay0601 Aug 7, 2023
868c4f1
Code Smells
dhananjay0601 Aug 8, 2023
875059a
Merge branch 'main' into port_number_placeholder
dhananjay0601 Aug 8, 2023
ae6d739
updated files
dhananjay0601 Aug 11, 2023
35b798b
minor change
dhananjay0601 Aug 11, 2023
ea71d50
flag for node
dhananjay0601 Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/appStore/InstalledAppRestHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import (
"github.com/devtron-labs/devtron/pkg/appStore/deployment/repository"
"github.com/devtron-labs/devtron/pkg/appStore/deployment/service"
"github.com/devtron-labs/devtron/pkg/cluster"
application2 "github.com/devtron-labs/devtron/pkg/k8s/application"
"github.com/devtron-labs/devtron/pkg/user"
"github.com/devtron-labs/devtron/pkg/user/casbin"
"github.com/devtron-labs/devtron/util"
Expand Down Expand Up @@ -80,6 +81,7 @@ type InstalledAppRestHandlerImpl struct {
argoUserService argo.ArgoUserService
cdApplicationStatusUpdateHandler cron.CdApplicationStatusUpdateHandler
installedAppRepository repository.InstalledAppRepository
K8sApplicationService application2.K8sApplicationService
}

func NewInstalledAppRestHandlerImpl(Logger *zap.SugaredLogger, userAuthService user.UserService,
Expand Down
Loading