Skip to content

feat: Flag to pass build platform globally #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2023
Merged

feat: Flag to pass build platform globally #3625

merged 3 commits into from
Jul 15, 2023

Conversation

@Ashish-devtron
Copy link
Contributor

@Ashish-devtron Ashish-devtron commented Jul 12, 2023 •
edited
Loading

Description

Need an option/flag to pass the build platform globally.

Fixes #3531

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ashish-devtron Ashish-devtron marked this pull request as ready for review July 12, 2023 13:52
@Ashish-devtron Ashish-devtron changed the title Default target platform Feature: Flag to pass build platform globally Jul 12, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kripanshdevtron kripanshdevtron changed the title Feature: Flag to pass build platform globally feat: Flag to pass build platform globally Jul 14, 2023
@Ashish-devtron Ashish-devtron merged commit 0bb20d6 into main Jul 15, 2023
@Ashish-devtron Ashish-devtron deleted the default-target-platform branch July 15, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Flag to pass build platform globally

3 participants

@Ashish-devtron @kripanshdevtron