Skip to content

Fix: SSO configuration gets change after refreshing the page #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix: SSO configuration gets change after refreshing the page #3605

merged 1 commit into from
Jul 11, 2023

Conversation

@Ashish-devtron
Copy link
Contributor

Description

After saving any SSO configuration it's getting saved correctly, but after refreshing the page it shows some fixed values for all the SSO login services.

Fixes #3540

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ashish-devtron Ashish-devtron marked this pull request as ready for review July 6, 2023 10:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashish-devtron Ashish-devtron merged commit 23291a9 into main Jul 11, 2023
@Ashish-devtron Ashish-devtron deleted the nil-credential-check branch July 11, 2023 07:20
@Ashish-devtron Ashish-devtron linked an issue Jul 11, 2023 that may be closed by this pull request
Bug: Incorrect Dex config when trying to use SSO private Gitlab instance. #3568
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Incorrect Dex config when trying to use SSO private Gitlab instance. Bug: SSO configuration gets change after refreshing the page

3 participants

@Ashish-devtron @vikramdevtron