Skip to content

fix: handled no config exists case for enforced deployment app type #3575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2023
Merged

fix: handled no config exists case for enforced deployment app type #3575

merged 6 commits into from
Jun 28, 2023

Conversation

@HimanshuJha2000
Copy link
Contributor

@HimanshuJha2000 HimanshuJha2000 commented Jun 28, 2023 •
edited
Loading

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@HimanshuJha2000 HimanshuJha2000 changed the title Fix : handled no config exists case for enforced deployment app type fix: handled no config exists case for enforced deployment app type Jun 28, 2023
vikramdevtron
vikramdevtron reviewed Jun 28, 2023
View reviewed changes
vikramdevtron
vikramdevtron reviewed Jun 28, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
81.2% 81.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@HimanshuJha2000 HimanshuJha2000 merged commit 044bd7d into main Jun 28, 2023
@HimanshuJha2000 HimanshuJha2000 deleted the fix/enforce-deployment-app-type branch June 28, 2023 10:53
gireesh-naidu pushed a commit that referenced this pull request Aug 13, 2023
@HimanshuJha2000
fix: handled no config exists case (#296)
7794174 
* chore: refactored failing test case (#3569)

* fix: handled no config exists case for enforced deployment app type (#3575)

* chore: handled no config exists case

* chore: handled no config exists case

* chore: handled no config exists case

* chore: handled no config exists case

* chore: added unit test case and refactoring

* chore: added unit test case and refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HimanshuJha2000 @vikramdevtron