Fix: argo workflow double encoding of secret value in template #3496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for key, value := range configMapSecretDto.Data { | ||
| secretDataMap[key] = []byte(value) | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add comment here, why we are doing this
| configSecretMap.MountPath = dto.MountPath | ||
| jsonRawMsg, err := json.Marshal(dto.Data) | ||
|
|
||
| if dto.ConfigType == repository.CS_TYPE_CONFIG { |
There was a problem hiding this comment.
Please add comment here, why we are doing that
|
Kudos, SonarCloud Quality Gate passed!
|
kripanshdevtron
approved these changes
Jun 8, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* fixing cs issue argo executor * cleaning * fix * addressed PRs
adi6859
pushed a commit
that referenced
this pull request
Jun 16, 2023
* fixing cs issue argo executor * cleaning * fix * addressed PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3493
argo workflow double encoding of secret value in template
How Has This Been Tested?
manually tested for config maps and secrets
Checklist:
Does this PR introduce a user-facing change?