Skip to content

Conversation

@subhashish-devtron
Copy link
Contributor

Description

Fixes #
Added support and logic to handle log location based on the key we provide for both CI and CD workflows and passed additional data to CI runner request

How Has This Been Tested?

Manual testing with CI runner changes

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


kripanshdevtron
kripanshdevtron previously approved these changes Jun 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kripanshdevtron kripanshdevtron self-requested a review June 8, 2023 03:56
@subhashish-devtron subhashish-devtron merged commit 526ab89 into main Jun 8, 2023
@subhashish-devtron subhashish-devtron deleted the archive-logs-final branch June 8, 2023 04:40
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
* archive logs sync

* added type for cdstage event

* test

* cleanup

* adding log file path to db on trigger

* cleanup

* cleanup

* cleanup

* cleanup

* exposed pod name in cd workflow details

* log path fix

* fix

* addresing pr comments

* addresing pr comments2

* addresing pr comments3

* fix

* Update CiHandler.go
adi6859 pushed a commit that referenced this pull request Jun 16, 2023
* archive logs sync

* added type for cdstage event

* test

* cleanup

* adding log file path to db on trigger

* cleanup

* cleanup

* cleanup

* cleanup

* exposed pod name in cd workflow details

* log path fix

* fix

* addresing pr comments

* addresing pr comments2

* addresing pr comments3

* fix

* Update CiHandler.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants