Skip to content

Conversation

@jatin-jangir-0220
Copy link
Contributor

@jatin-jangir-0220 jatin-jangir-0220 commented May 16, 2023

Description

Fixes #

How Has This Been Tested?

create a devtron application, and in base deployment template change the enable for autoscaling and kedaAutoscaling.

Test-cases

  • Test case A : both are true -- show error
  • Test case B : any one is true -- no error
  • Test case C : both false -- no error

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented May 17, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 922d743 scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/env-values.yaml View secret
- Generic High Entropy Secret 922d743 scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
10.0% 10.0% Duplication

@prakarsh-dt prakarsh-dt merged commit 260f871 into devtron-labs:main May 29, 2023
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
* updated audit info for cd pipeline delete req (#3404)

* feat: Added condition for notifying HPA if Keda is enabled and handle HPA part in KEDA  (#3391)

* added condition for kedaAutoScaleEnabled

* added new notification line

* added nil condition

---------

Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: jatin-jangir-0220 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants