task: changes for kubelink update application requests #3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
kripanshdevtron
approved these changes
May 9, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* feat: Approval node scripts (#3345) * approval node scripts * go template with missing key handling * approver param added * reverted TPrintf func * approver param type change * script number updated * script version update * script number updated * enhancement: made revision history limit configurable for helm upgrade (#3353) * made revision history limit configurable for helm upgrade * review changes * updated fieldName * renamed constS * added deployment_strategy_ref_mapping_removal (#3362) * task: changes for kubelink update application requests (#3359) * changes for kubelink - update application requests * added bean.go --------- Co-authored-by: kripanshdevtron <[email protected]> Co-authored-by: Pawan Kumar <[email protected]>
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* feat: Approval node scripts (#3345) * approval node scripts * go template with missing key handling * approver param added * reverted TPrintf func * approver param type change * script number updated * script version update * script number updated * enhancement: made revision history limit configurable for helm upgrade (#3353) * made revision history limit configurable for helm upgrade * review changes * updated fieldName * renamed constS * added deployment_strategy_ref_mapping_removal (#3362) * task: changes for kubelink update application requests (#3359) * changes for kubelink - update application requests * added bean.go * fix: updated rbac for fetching all default role (#3363) * updated rbac for fetching all default role * moved method to get rbac team names to enforcerUtil --------- Co-authored-by: kripanshdevtron <[email protected]> Co-authored-by: Pawan Kumar <[email protected]>
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* feat: Approval node scripts (#3345) * approval node scripts * go template with missing key handling * approver param added * reverted TPrintf func * approver param type change * script number updated * script version update * script number updated * enhancement: made revision history limit configurable for helm upgrade (#3353) * made revision history limit configurable for helm upgrade * review changes * updated fieldName * renamed constS * added deployment_strategy_ref_mapping_removal (#3362) * task: changes for kubelink update application requests (#3359) * changes for kubelink - update application requests * added bean.go * fix: updated rbac for fetching all default role (#3363) * updated rbac for fetching all default role * moved method to get rbac team names to enforcerUtil * enhancement: made pipeline status crons cascading (#3372) * made pipeline status crons cascading, added metrics for cron process duration * updated defer calls * updated label for cron status metric --------- Co-authored-by: kripanshdevtron <[email protected]> Co-authored-by: Pawan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update method structure for updating application through kubelink apis. Renamed constants with better meaning.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?