Skip to content

Conversation

@subhashish-devtron
Copy link
Contributor

@subhashish-devtron subhashish-devtron commented May 9, 2023

Description

Fixes #
#3109
added handling for failed step name in CI messages, sending failure notification through CI complete topic instead of workflow update topic to be able to pass details from CI runner for run failures

How Has This Been Tested?

Tested manually for success and failed cases on events to notifier with the new data

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


gireesh-naidu
gireesh-naidu previously approved these changes May 12, 2023
@subhashish-devtron subhashish-devtron merged commit aea4118 into main May 15, 2023
@subhashish-devtron subhashish-devtron deleted the feat-step-failure-notif branch May 15, 2023 14:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Notification to get which steps fail in build process and its metadata as well.

4 participants