feat: Change cd deployment type #3332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| resp, err := handler.pipelineBuilder.ChangePipelineDeploymentType(ctx, deploymentTypeChangeRequest) | ||
|
|
||
| if err != nil { | ||
| nErr := errors.New("failed to change deployment type with error msg: " + err.Error()) |
There was a problem hiding this comment.
we can use format printer
|
|
||
| func (handler PipelineConfigRestHandlerImpl) HandleTriggerDeploymentAfterTypeChange(w http.ResponseWriter, r *http.Request) { | ||
|
|
||
| // Auth check |
| func (impl PipelineRepositoryImpl) UpdateCdPipeline(pipeline *Pipeline) error { | ||
| err := impl.dbConnection.Update(pipeline) | ||
| func (impl PipelineRepositoryImpl) SetDeploymentAppCreatedInPipeline(deploymentAppCreated bool, pipelineId int, userId int32) error { | ||
| query := "update pipeline set deployment_app_created=?, updated_on=?, updated_by=? where id=?;" |
There was a problem hiding this comment.
avoid writing native queries
| query := "update pipeline set deployment_app_created = ?, deployment_app_type = ?, " + | ||
| "updated_by = ?, updated_on = ?, deployment_app_delete_request = ? where id in (?);" | ||
| var pipeline *Pipeline | ||
| _, err := impl.dbConnection.Query(pipeline, query, deploymentAppCreated, deploymentAppType, userId, time.Now(), delete, pg.In(cdPipelineIdIncludes)) |
There was a problem hiding this comment.
check empty array for pg.In
| "updated_by = ?, updated_on = ?, deployment_app_delete_request = ? where id in (?);" | ||
| var pipeline *Pipeline | ||
| _, err := impl.dbConnection.Query(pipeline, query, deploymentAppType, userId, time.Now(), pg.In(cdPipelineIdIncludes)) | ||
| _, err := impl.dbConnection.Query(pipeline, query, deploymentAppType, userId, time.Now(), delete, pg.In(cdPipelineIdIncludes)) |
|
|
||
| for _, pipeline := range pipelines { | ||
|
|
||
| artifactDetails, err := impl.RetrieveArtifactsByCDPipeline(pipeline, "DEPLOY") |
There was a problem hiding this comment.
is it possible to extract out from iteration
pkg/pipeline/PipelineBuilder.go
Outdated
| } | ||
| _, err = impl.application.Get(ctx, req) | ||
| } | ||
| fmt.Println(err.Error() == "rpc error: code = NotFound desc = error getting application: applications.argoproj.io \"app-1-test-env\" not found") |
vikramdevtron
previously approved these changes
May 9, 2023
|
SonarCloud Quality Gate failed.
|
vikramdevtron
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, two API is being introduced to change the deployment type for all cd pipelines in an environment and trigger the deploy for the same.
Fixes #https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/2870
Checklist: