feat: added deployedBy field in helm apps deployment history #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash100198
previously approved these changes
Apr 27, 2023
| return result, err | ||
| } | ||
| for _, updateHistory := range versionHistory { | ||
| user, _ := impl.userService.GetById(updateHistory.CreatedBy) |
There was a problem hiding this comment.
error handling missing
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Apr 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added and passed the deployedBy field in helm apps deployment history but not in the case of app deployed through external apps.
Fixes 2847
How Has This Been Tested?
1: Created deployedBy in the preview to be passed.
2: Got that value from the database and recieved it on the frontEnd.
3: Checked through various apps whether the deployedBy field is coming on the preview and UI or not, it is working fine.
Checklist: