feat: optimised user addition/creation flows #3274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik-579
changed the title
nishant-d
previously approved these changes
Apr 16, 2023
|
SonarCloud Quality Gate failed.
|
nishant-d
approved these changes
Apr 18, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* added new default rbac policy, role structure and caching * renamed sql tables and files for supporting preset and custom roles * added notnull tag for deleted field in RbacRoleData db obj * renaming fixes * updated sql script no * updated signature * made default policy/role methods creation/updation transactional * updated role description and role display name in sql * fix in repository method * updated update method for default role, policy * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new default rbac policies and role structure. Cached both of them and added own rendering logic for faster processing.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?