fix: updated condition for getting role filters #3261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
kartik-579
changed the title
kripanshdevtron
approved these changes
Apr 10, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* chore: Discord notification for a specific label ("pager-duty") (#3249)
* new action added
* changes
* changes
---------
Co-authored-by: Kamal Acharya <[email protected]>
* action added (#3265)
Co-authored-by: Kamal Acharya <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
* fix: updated condition for getting role filters (#3261)
* removed code which was corrupting data for role filters
* updated condition for user data fetch api role filters dml handling
* wip
---------
Co-authored-by: kamal-devtron <[email protected]>
Co-authored-by: Kamal Acharya <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* chore: Discord notification for a specific label ("pager-duty") (#3249)
* new action added
* changes
* changes
---------
Co-authored-by: Kamal Acharya <[email protected]>
* action added (#3265)
Co-authored-by: Kamal Acharya <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
* fix: updated condition for getting role filters (#3261)
* removed code which was corrupting data for role filters
* updated condition for user data fetch api role filters dml handling
* wip
* fix: updated condition for handling linked ci creation with parent ci docker config overriden (#3243)
* fix for linked ci creation
* fix for linked ci delete panic
* wip
---------
Co-authored-by: kamal-devtron <[email protected]>
Co-authored-by: Kamal Acharya <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated condition (dml handling for updated accessType and entity) for getting filtered role filters.
Fixes #3266
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?