Skip to content

fix: bulk cd deployment trigger failing #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 7, 2023
Merged

fix: bulk cd deployment trigger failing #3233

merged 12 commits into from
Apr 7, 2023

Conversation

@vishal-dt
Copy link
Contributor

@vishal-dt vishal-dt commented Apr 4, 2023 •
edited
Loading

Description

Bulk CD deployment trigger is failing as it is currently executed as synchronous operation. With this PR, this process is being made async.

Fixes #3234

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Private cluster

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

NO

@vishal-dt vishal-dt requested a review from vikramdevtron April 4, 2023 20:09
vikramdevtron
vikramdevtron reviewed Apr 5, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vishal-dt vishal-dt requested review from kartik-579 and removed request for kartik-579 April 7, 2023 11:45
@vishal-dt vishal-dt merged commit f794875 into main Apr 7, 2023
@vishal-dt vishal-dt deleted the fix-bulk-cd-trigger-failing branch April 7, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron left review comments

+1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: bulk CD deployment trigger api is failing

4 participants

@vishal-dt @vikramdevtron @kripanshdevtron