Skip to content

fix: select image not working for external webhook #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2023
Merged

fix: select image not working for external webhook #3187

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f00ecb
wip
iamayushm Mar 24, 2023
8574a8f
wip
iamayushm Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/pipeline/PipelineBuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2744,6 +2744,10 @@ func (impl PipelineBuilderImpl) GetArtifactsForCdStage(cdPipelineId int, parentI
}
for i, artifact := range ciArtifacts {
artifactBean, err := impl.ciArtifactRepository.Get(artifact.Id)
if artifactBean.ExternalCiPipelineId != 0 {
// if webhook continue
continue
}
if err != nil {
Copy link
Member

@kartik-579 kartik-579 Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle error before condition

impl.logger.Errorw("error in getting artifactBean for one ci_artifact", "err", err, "parentStage", parentType, "stage", stage)
return ciArtifactsResponse, err
Expand Down