fix:notes.txt throws error when charts require special KubeVersion #3170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| k8sServerVersion, err := discoveryClient.ServerVersion() | ||
| if err != nil { | ||
| impl.logger.Errorw("exception caught in getting k8sServerVersion", "err", err) |
There was a problem hiding this comment.
create one function in k8s util and use that for this version
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the notes.txt generation error (as shown below) when charts require special KubeVersion.
Fixes AB2520
How Has This Been Tested?
Test cases are:-
a.deployed helm chart when no apps is present.
b. deployed same helm chart again when above app is present.
c.deployed helm chart via gitOps.
Checklist: