feat: validate kubeconfig and save clusters #3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghildiyal
reviewed
Mar 23, 2023
api/cluster/ClusterRestHandler.go
Outdated
| //} | ||
|
|
||
| // RBAC enforcer applying | ||
| if ok := impl.enforcer.Enforce(token, casbin.ResourceCluster, casbin.ActionCreate, "*"); !ok { |
There was a problem hiding this comment.
this should be superadmin check
There was a problem hiding this comment.
Ok doing that
pghildiyal
reviewed
Mar 23, 2023
api/cluster/ClusterRestHandler.go
Outdated
| } | ||
| result := []cluster.ClusterBean{} | ||
| for _, bean := range beans { | ||
| res, err := impl.clusterService.Save(ctx, &bean, userId) |
There was a problem hiding this comment.
we should not call our own service within orchestrator with token
|
SonarCloud Quality Gate failed.
|
gireesh-naidu
approved these changes
Jun 2, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Developed two nwe apis
Fixes #852
How Has This Been Tested?
Checklist: