Skip to content

fix: apps in progressing state indefinitely #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix: apps in progressing state indefinitely #3137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/pipeline/CdHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,20 @@ func (impl *CdHandlerImpl) CheckHelmAppStatusPeriodicallyAndUpdateInDb(helmPipel
//return err
//skip this error and continue for next workflow status
impl.Logger.Warnw("found error, skipping helm apps status update for this trigger", "appIdentifier", appIdentifier, "err", err)
continue

// Handle release not found errors
if !strings.Contains(err.Error(), "release: not found") {
continue
}
}
if helmAppStatus == application.Healthy {
wfr.Status = pipelineConfig.WorkflowSucceeded
wfr.FinishedOn = time.Now()

} else if err != nil && strings.Contains(err.Error(), "release: not found") {
// If release not found, mark the deployment as failure
wfr.Status = pipelineConfig.WorkflowFailed

} else {
wfr.Status = pipelineConfig.WorkflowInProgress
}
Expand Down