Skip to content

feat: export pg query metrics to prometheus #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2023
Merged

feat: export pg query metrics to prometheus #3118

merged 3 commits into from
Mar 15, 2023

Conversation

@vishal-dt
Copy link
Contributor

@vishal-dt vishal-dt commented Mar 15, 2023 •
edited
Loading

Description

Expose pg query metrics to prometheus

New env variables:

  • PG_EXPORT_PROM_METRICS - Flag to enable/disable pg query metrics

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

NO

@vishal-dt vishal-dt requested a review from nishant-d March 15, 2023 10:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vishal-dt vishal-dt requested a review from kartik-579 March 15, 2023 11:18
@vishal-dt vishal-dt merged commit b9f1420 into main Mar 15, 2023
@vishal-dt vishal-dt deleted the feat-add-pg-query-prom-metrics branch March 15, 2023 11:19
kartik-579 pushed a commit that referenced this pull request Mar 28, 2023
@vishal-dt @Shivam-nagar23
feat: export pg query metrics to prometheus (#3118)
6dbf29e 
* expose prometheus metrics for pg query

* add env variable for flag

* remove query label from pg prom metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartik-579 kartik-579 kartik-579 approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishal-dt @kartik-579